Skip to content

Conversation

@mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Sep 6, 2022

Description

Make nightly builds of WM & TM container images from develop every night 12AM PT/ 7AM UTC

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

@mocsharp mocsharp added the build label Sep 6, 2022
@mocsharp mocsharp self-assigned this Sep 6, 2022
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #407 (4f6c540) into develop (bb565e1) will decrease coverage by 0.08289%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #407         +/-   ##
===================================================
- Coverage   57.09003%   57.00714%   -0.08289%     
===================================================
  Files            125         125                 
  Lines          15684       15684                 
  Branches        1665        1665                 
===================================================
- Hits            8954        8941         -13     
- Misses          6454        6469         +15     
+ Partials         276         274          -2     
Flag Coverage Δ
unittests 57.00714% <ø> (-0.08289%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/TaskManager/API/MetadataRepositoryBase.cs 11.11111% <0.00000%> (-38.88890%) ⬇️
...ug-ins/Argo/Repositories/ArgoMetadataRepository.cs 69.76744% <0.00000%> (-9.30234%) ⬇️
src/TaskManager/API/TaskPluginBase.cs 88.23529% <0.00000%> (-5.88236%) ⬇️
src/TaskManager/Plug-ins/Argo/ArgoPlugin.cs 88.24561% <0.00000%> (-0.17544%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb565e1...4f6c540. Read the comment docs.

Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mocsharp mocsharp merged commit ab419fa into develop Sep 7, 2022
@mocsharp mocsharp deleted the vchang/nightly-build branch September 7, 2022 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants